Quotes pointing to deleted post gets stuck loading

Go to the following post:

Try load the full quote and you’ll get the Loading... text and it’ll stay there. You can’t toggle it back either; it’s stuck in that operation.

2 Mi Piace

This is more or less by design.. the only improvement would be for “loading…” to say “post was deleted” instead. So it’s a feature req.

1 Mi Piace

Well, clicking the toggle also gets you into an unrecoverable state (without refresh) where you can’t toggle back to the on-page quote. That’s a minor bug imo.

As for how to keep users from encountering it, I suppose the simplest fix of all would be to not display the toggle-arrow if the topic no longer exists.

Can’t know that until we check on click.

Okay, but the code can tell when the request failed, and go back to the original state. We could fix that.

4 Mi Piace

This “issue” is still here on Meta (example in the OP of this topic https://meta.discourse.org/t/cross-origin-framing/26984) exactly as described by @erlend_sh

I think that new user can be really in difficult to understand what’s happening, the only way to see what is wrong is open the browser console and look at the error Not Found.

Change Loading... with This post was deleted, as @codinghorror said above, is a good compromise to me.

4 Mi Piace

Sure can you make that change @eviltrout? This one is long overdue.

3 Mi Piace

I think this was done? If I try as anonymous I get a trash icon instead.

3 Mi Piace

Good ol’ @neil did it!

3 Mi Piace

Sembra che qui ci sia una sorta di regressione. Date un’occhiata al link incorporato Manually update Discourse and Docker image to latest - #112 di Dean: viene visualizzato un «caricamento» infinito. Funziona ancora per le citazioni semplici che contengono un link, ma non per un argomento/post collegato eliminato.


AGGIORNAMENTO: Guardando il post originale di questo argomento, sembra che non funzioni con un link all’interno di una citazione. Mostra «caricamento» per meno di un secondo, ma non visualizza l’icona «cestino» che indica che il link/testo di riferimento è stato eliminato. In questo caso, un utente normale tende a cliccare sul link nella citazione e finisce sulla pagina 404.

Quindi funziona solo con citazioni di testo molto semplici, senza link all’interno.

2 Mi Piace

Is this fixable easily @eviltrout? Maybe take a peek Monday.

1 Mi Piace

Looks like the bug was where the post was in a deleted topic (but the post was not deleted) it would return InvalidAccess instead of a 404. This fixes it and shows the trash can again.

https://github.com/discourse/discourse/commit/89a1b34480e89e8dc1d47c749f08ed1225a173e4

3 Mi Piace